Change limit from 750 char to words #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
nerdalert
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with Taxonomy Traiger team, it was concluded that at this point of time, having a 750 max words limit is a better constraint compared to 750 char.
Ideally this constraints should be enforced based on the number of tokens. Each model can have it's own way of splitting the string in the tokens, so determining number of tokens in any string depends on the model. Having a tokenizer service, that exposes a REST API to return the numbers of tokens in the provided string based on the base model, would be a really useful service in this scenario. We can leverage that to enforce the limits in terms of token.