Add about us modal #183
Add about us modal #183
Conversation
Signed-off-by: Patryk-Pierzchala1 <patryk.pierzchala1@ibm.com>
6143f57 to
5aef87b
Compare
| </div> | ||
| <div className={styles.joinCommunityButtonWrapper}> | ||
| <Button variant="primary" icon={<GithubIcon />} iconPosition="left" size="lg" className={styles.joinCommunityButton}> | ||
| Join the community |
There was a problem hiding this comment.
@vishnoianil @nerdalert do we have a way to link people to join the instructlab community? At present this does not link the user to anywhere.
There was a problem hiding this comment.
@aevo98765 we should point it to https://github.com/instructlab
|
Nice submission @itspatys! I have left a few comments but after they have been resolved it's a LGTM from me. |
Signed-off-by: Patryk-Pierzchala1 <patryk.pierzchala1@ibm.com>
|
Looks good just a few minor tweaks. Some maybe fine as is but it's hard for me to accurately judge color on video:
|
Hey @Misjohns , is there a way we can access these specific requirements as devs so we can implement these specifics as a first pass? Could we detail these as requirements in the issue? |
|
I can either give you access to the Figma file or create a quick red line to spec fonts, colors, etc. Which is better for you? |
Let's chat about it in the community meeting tomorrow. This would be good to have a consistent approach going forward as I think we should take as much guidance as possible from you guys early on. |
+1, @aevo98765 / @Misjohns Added this as an agenda item for community meeting. |
|
@vishnoianil I will try, but currently I am on vacation and I am not sure if I will have the time |
no worries at all, enjoy your vacations, last thing i want is folks to look at their laptop during their day off :-) |
Signed-off-by: Ash Evans <70710356+aevo98765@users.noreply.github.com>
Signed-off-by: Ash Evans <70710356+aevo98765@users.noreply.github.com>
Signed-off-by: Ash Evans <70710356+aevo98765@users.noreply.github.com>
…t function. Signed-off-by: Ash Evans <70710356+aevo98765@users.noreply.github.com>
…ctlab Signed-off-by: Ash Evans <70710356+aevo98765@users.noreply.github.com>
As @vishnoianil said. Prioritise your vacation! I have completed the changes and also caught (and sorted) some issue with the AboutModal not having an aria-label for accessibility. Going to push this one through. |
|
@vishnoianil @Misjohns looks like I can't review now. When you get chance I would appreciate a review. Thanks! |
|
Placed the changes beside design mockup so you can easily compare |
|
Link to Figma dev mode for About screen: https://www.figma.com/design/6QLf45DArE6d3ngxRSYarO/InstructLab?node-id=73-7952&m=dev Let me know if you can access it. |
Addresses: #102
about.us.modal.demo.mov
Please let me know what you think. I've tried making some of the text lighter but for some reason changing
font-weighttolighteror300doesn't work.