Environment variable fixes (redun init and db creds) #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrasmus
commented
May 29, 2025
| @@ -3144,18 +3144,31 @@ def _get_uri_from_secret(secret_name: str) -> str: | |||
| def _get_credentialed_uri(base_uri: str, conf: Section) -> str: | |||
| parts = urlparse(base_uri) | |||
|
|
|||
| if "@" in parts.netloc: | |||
| if parts.password: | |||
There was a problem hiding this comment.
Before we didn't allow even a username to be passed. Usernames are fine. Instead let's just test for the presence of passwords, which is what we really care about.
mattrasmus
commented
May 29, 2025
| args.config = os.path.join(basedir, REDUN_CONFIG_DIR) | ||
|
|
||
| else: | ||
| args.config = get_config_dir(args.config) |
There was a problem hiding this comment.
Using get_config_dir() makes use of all usual ways of discovering the config dir (env var, args, etc).
|
This is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120 and #121