8000 add more rich_escape calls by mattrasmus · Pull Request #119 · insitro/redun · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add more rich_escape calls #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

add more rich_escape calls #119

merged 1 commit into from
May 23, 2025

Conversation

mattrasmus
Copy link
Collaborator

Addresses #117

Some text was not escaped properly for rich styling. This was exposed by a new version of textual.

@mattrasmus mattrasmus requested a review from pkaleta May 23, 2025 00:04
@mattrasmus mattrasmus mentioned this pull request May 23, 2025
Closed
pkaleta
pkaleta approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor
@pkaleta pkaleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM. :shipit: assuming you're able to reproduce the problem and this fixed it.

@mattrasmus
Copy link
Collaborator Author

assuming you're able to reproduce the problem and this fixed it.

Yep. Thanks for the quick review.

@mattrasmus mattrasmus merged commit 733ffb3 into main May 23, 2025
10 checks passed
@mattrasmus mattrasmus deleted the add-more-rich-escape branch May 23, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkaleta pkaleta pkaleta approved these changes

@ctk3b ctk3b ctk3b approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattrasmus @pkaleta @ctk3b
0