8000 Remove console debug logger by mattrasmus · Pull Request #115 · insitro/redun · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove console debug logger #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

Remove console debug logger #115

merged 2 commits into from
Mar 14, 2025

Conversation

mattrasmus
Copy link
Collaborator

Addresses #109

This logger was actually just added for debugging and is not actively used in the code. We can remove it to avoid this issue.

@mattrasmus mattrasmus force-pushed the remove-console-debug-logger branch from 1a7168c to fdf3bfb Compare March 14, 2025 14:09
@mattrasmus mattrasmus requested a review from pkaleta March 14, 2025 14:10
pkaleta
pkaleta approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor
@pkaleta pkaleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I double checked and i don't think either the logger or the removed function is used anywhere

@mattrasmus mattrasmus merged commit 2548d17 into main Mar 14, 2025
6 checks passed
@mattrasmus mattrasmus deleted the remove-console-debug-logger branch March 14, 2025 15:03
This was referenced Mar 14, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkaleta pkaleta pkaleta approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattrasmus @pkaleta
0