8000 feat: v1.0.0 upgrade by beer-1 · Pull Request #392 · initia-labs/initia · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: v1.0.0 upgrade #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2025
Merged

feat: v1.0.0 upgrade #392

merged 3 commits into from
Apr 18, 2025

Conversation

beer-1
Copy link
Member
@beer-1 beer-1 commented Apr 17, 2025 •
edited
Loading

Description

  • Create v1.0.0 upgrade handler
  • Bump movevm to v1.0.0
    • Patch security update from Aptos Move
    • Fix final audit findings
  • Bump OPinit to v1.0.0

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@beer-1 beer-1 added the v1 Release v1 label Apr 17, 2025
@beer-1 beer-1 self-assigned this Apr 17, 2025
@beer-1 beer-1 requested a review from a team as a code owner April 17, 2025 04:50
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Apr 17, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The changes update the upgrade name constant from a release candidate to a final version and significantly simplify the upgrade logic. All code related to reading upgrade information from disk, checking upgrade names and heights, and setting up store loaders with store upgrades has been removed. The upgrade handler function is now minimal, immediately returning the input version map without performing any parameter updates or error handling. Associated imports for the removed logic have also been deleted. Additionally, the Dockerfile was updated to use the stable MoveVM library version instead of the release candidate. The JSON ABI for the BasicCoin module was modified to include an "is_event" boolean field for certain structs, distinguishing event types from non-event types.

Changes

File(s) Change Summary
app/upgrade.go Changed upgrade name constant from "v1.0.0-rc.0" to "v1.0.0"; removed disk upgrade info checks, store loader logic, parameter updates in the upgrade handler; deleted related imports.
Dockerfile Updated LIBMOVEVM_VERSION environment variable from v1.0.0-rc.1 to v1.0.0.
x/move/keeper/common_test.go Added "is_event" boolean field to the JSON ABI structs for BasicCoin module, marking MintEvent and ViewEvent as events (true), others as non-events (false).

Poem

A hop, a skip, an upgrade anew,
The code is lighter, the logic trimmed through.
Gone are the checks and the old upgrade lore,
Now the handler is simple—no fuss anymore!
With version advanced and errors at bay,
The rabbit leaps forward—hip hip hooray!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Lite

📥 Commits

Reviewing files that changed from the base of the PR and between 05b4543 and 09315ac.

⛔ Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (2)
  • Dockerfile (1 hunks)
  • x/move/keeper/common_test.go (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • Dockerfile
  • x/move/keeper/common_test.go
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 17, 2025 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 3 package(s) with unknown licenses.
See the Details below.

License Issues

go.mod

PackageVersionLicenseIssue Type
github.com/initia-labs/OPinit1.0.0NullUnknown License
github.com/initia-labs/OPinit/api1.0.0NullUnknown License
github.com/initia-labs/movevm1.0.0NullUnknown License
Denied Licenses: GPL-1.0-or-later, LGPL-2.0-or-later

OpenSSF Scorecard

PackageVersionScoreDetails
gomod/github.com/cosmos/iavl 1.2.5 🟢 6.4
Details
CheckScoreReason
Code-Review🟢 9Found 22/24 approved changesets -- score normalized to 9
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
Maintained🟢 1014 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Packaging⚠️ -1packaging workflow not detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Vulnerabilities🟢 37 existing vulnerabilities detected
SAST🟢 10SAST tool is run on all commits
gomod/github.com/initia-labs/OPinit 1.0.0 UnknownUnknown
gomod/github.com/initia-labs/OPinit/api 1.0.0 UnknownUnknown
gomod/github.com/initia-labs/movevm 1.0.0 UnknownUnknown

Scanned Files

  • go.mod

@codecov Codecov
Copy link
codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.18%. Comparing base (92df11e) to head (09315ac).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   40.07%   40.18%   +0.10%     
==========================================
  Files         294      294              
  Lines       27511    27542      +31     
==========================================
+ Hits        11025    11067      +42     
+ Misses      14785    14772      -13     
- Partials     1701     1703       +2
Files with missing lines Coverage Δ
app/upgrade.go 50.00% <ø> (+38.23%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beer-1 beer-1 changed the title feat: v1.0.0 upgrade handler feat: v1.0.0 upgrade Apr 18, 2025
@beer-1 beer-1 merged commit 8f1271e into main Apr 18, 2025
10 checks passed
@beer-1 beer-1 deleted the feat/v1.0.0 branch April 18, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@beer-1 beer-1

Labels
v1 Release v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beer-1
0