This repository was archived by the owner on Dec 31, 2022. It is now read-only.
Add GetMouseCursor, SetConfigFlags and SetBackendFlags functions #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dertseha
suggested changes
May 18, 2019
ConfigFlags.go
Outdated
| ConfigFlagNoMouseCursorChange | ||
|
|
||
| // User storage (to allow your back-end/engine to communicate to code that may be shared between multiple projects. Those flags are not used by core ImGui) | ||
| ConfigFlagIsSRGB = 1 << 20 // Application is SRGB-aware. |
There was a problem hiding this comment.
Please set the comments above the constants
MouseCursorFlags.go
Outdated
| // User code may request binding to display given cursor by calling SetMouseCursor(), which is why we have some cursors that are marked unused here | ||
| MouseCursorNone = iota - 1 | ||
| MouseCursorArrow | ||
| MouseCursorTextInput // When hovering over InputText, etc. |
There was a problem hiding this comment.
Please set the comments above the constants
imgui.go
Outdated
|
|
||
| // GetMouseCursor returns desired cursor type, reset in imgui.NewFrame(), this is updated during the frame. | ||
| // Valid before Render(). If you use software rendering by setting io.MouseDrawCursor ImGui will render those for you. | ||
| func GetMouseCursor() int { |
There was a problem hiding this comment.
Getters in Go are without the prefix Get - please remove.
golangcibot
reviewed
May 18, 2019
golangcibot
reviewed
May 18, 2019
|
Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.