Add dummy files to preserve vendor directories #172
Conversation
|
I renamed the files to govendorkeep (similar to how gitkeep is used in git to commit empty directories). However I don't know what to do about the failed tests. I tested everything locally and it worked fine. |
Co-authored-by: Christian Haas <christian.haas@sevensuns.at>
This probably comes from the now new package to not use cgo in case of |
|
Looks like, the whole directories must be excluded on linting. Should be fixed now. |
|
Does the linter in github actions use a different config file than .golangci.yml? I've tested it locally with the docker command documented on the golangci-lint website |
|
Hm. The action does use an older version of golangci-lint ( Simply upgrading the action might add way more issues, as the config is still in the "old" format of simply enabling "all" linters. What will be necessary is to instead of enabling all, explicitly enable only those that were in the used version so far, then the version could be upgraded. |
|
I meant skipping the directories went fine. But I will try to update the linter and the config. |
|
Great - working now! |
When using
go mod vendor, directories without any go files are automatically deleted. This causes errors because the cgo includes cannot be found anymore. This PR adds dummy files to prevent go vendor from deleting these directories.For reference go-gl/glfw does the same: go-gl/glfw@0e1e096
golang/go#26366