enhance: Update PR comment's cost change summary #3099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fcd4aa to
c53709e
Compare
Keeping .Root.CloudURL as it's used for Bitbucket as it doesn't support collapsed sections.
c53709e to
1c7c864
Compare
tim775
requested changes
Jun 27, 2024
internal/output/diff.go
Outdated
| @@ -188,11 +188,18 @@ func tableForDiff(out Root, opts Options) string { | |||
| continue | |||
| } | |||
|
|
|||
| var usageCost string | |||
| if out.Metadata.UsageApiEnabled { | |||
There was a problem hiding this comment.
I'm worried that this condition is not sufficient because usage costs can also come from the usage file. Essentially, we only want to show the "-" when usageCostsMessage is the "Usage costs CAN be estimated..." one. It looks like that works out to showing - when !out.Metadata.UsageApiEnabled && out.Metadata.UsageFilePath == "" && !out.Metadata.ConfigFileHasUsageFile
as a sanity check in the API comment I also checked to make sure that both usage costs were zero or not present (I was worried about putting in a "-" and then having the total change not equal baseline change.
1c7c864 to
dc5f235
Compare
vdmgolub
commented
Jun 27, 2024
cmd/infracost/testdata/diff_terraform_plan_json/diff_terraform_plan_json.golden
Outdated
Show resolved
Hide resolved
vdmgolub
commented
Jun 27, 2024
dc5f235 to
bf4f8c3
Compare
tim775
approved these changes
Jun 28, 2024
vdmgolub
commented
Jun 28, 2024
| formatMarkdownCostChange(out.Currency, project.PastBreakdown.TotalMonthlyUsageCost, project.Breakdown.TotalMonthlyUsageCost, false, true), | ||
| formatMarkdownCostChange(out.Currency, project.PastBreakdown.TotalMonthlyCost, project.Breakdown.TotalMonthlyCost, false, false), | ||
| formatMarkdownCostChange(out.Currency, project.PastBreakdown.TotalMonthlyBaselineCost(), project.Breakdown.TotalMonthlyBaselineCost(), false, true, false), | ||
| formatMarkdownCostChange(out.Currency, project.PastBreakdown.TotalMonthlyUsageCost, project.Breakdown.TotalMonthlyUsageCost, false, true, !usageCostsEnabled(out)), |
There was a problem hiding this comment.
@tim775 This should also be inverted: when usage costs are disabled, skipIfZero is true, so we'll show dashes for zeros.
ce23a01 to
df35f67
Compare
df35f67 to
e5464b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.