8000 Random tests cleanups by alexfikl · Pull Request #919 · inducer/loopy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Random tests cleanups #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2025
Merged

Random tests cleanups #919

merged 4 commits into from
Feb 19, 2025

Conversation

alexfikl
Copy link
Contributor
  • Add error codes to noqa comments.
  • Remove faulthandler imports. As far as I know, this can be enabled with -X faulthandler now.
  • Use logger.info instead of print everywhere. Should make tests less chatty.

@inducer inducer enabled auto-merge (rebase) February 19, 2025 15:41
@inducer
Copy link
Owner
inducer commented Feb 19, 2025

Thanks, this all looks good, except for the print changes. I've separated those out into #920 for discussion.

@inducer inducer merged commit d32e610 into inducer:main Feb 19, 2025
18 checks passed
@alexfikl alexfikl deleted the cleanup-tests branch February 19, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4DD0
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfikl @inducer
0