8000 Strictly type everything by alexfikl · Pull Request #52 · inducer/codepy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Strictly type everything #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 10, 2025
Merged

Strictly type everything #52

merged 6 commits into from
Jan 10, 2025

Conversation

alexfikl
Copy link
Contributor
@alexfikl alexfikl commented Jan 9, 2025

This adds strict typing to the remaining modules as well and removes the ignore on cgen, since that's strictly typed now too.

@alexfikl
Copy link
Contributor Author
alexfikl commented Jan 9, 2025

Hm, this seems to be installing cgen from PyPI and is unhappy about the lack of annotations there :(

@inducer
Copy link
Owner
inducer commented Jan 9, 2025

I think it'd need a requirements.txt file pointing at the git tree to avoid that.

@alexfikl
Copy link
Contributor Author
alexfikl commented Jan 9, 2025

I think it'd need a requirements.txt file pointing at the git tree to avoid that.

Yep, that worked nicely. Thanks! 😁

inducer
inducer reviewed Jan 9, 2025
View reviewed changes
pyproject.toml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable mypy strict mdoe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was already turned on in #49. This PR just removes the ignores for the remaining files.

@inducer inducer merged commit 8b9c000 into inducer:main Jan 10, 2025
7 checks passed
@inducer
Copy link
Owner
inducer commented Jan 10, 2025

Thx!

@alexfikl alexfikl deleted the more-strict-mypy branch January 10, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer inducer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfikl @inducer
0