FRI rust wrappers #813
Merged
FRI rust wrappers #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
reviewed
Apr 23, 2025
yshekel
reviewed
Apr 23, 2025
yshekel
reviewed
Apr 23, 2025
yshekel
reviewed
Apr 23, 2025
yshekel
reviewed
Apr 23, 2025
yshekel
reviewed
Apr 23, 2025
| &merkle_tree_compress_hash, | ||
| ) | ||
| .unwrap(); | ||
| stream |
There was a problem hiding this comment.
minor but you need to release the stream here or it leaks
There was a problem hiding this comment.
probably that's why tests failed (I hope)
There was a problem hiding this comment.
I don't think it should make the tests fail but you should see a warning I think when dropping the rust object
yshekel
reviewed
Apr 23, 2025
| } | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
I think no test is testing the trait FriProofTrait
yshekel
reviewed
Apr 23, 2025
thanks for the mention, will add it too, the pr was just opened before we supported this field |
LeonHibnik
approved these changes
Apr 23, 2025
A3E2
ChickenLover
approved these changes
Apr 23, 2025
LeonHibnik
approved these changes
Apr 23, 2025
jeremyfelder
approved these changes
Apr 24, 2025
yshekel
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds FRI rust wrappers into icicle
cuda-backend-branch: main