8000 Bump node from 18.17.1 to 20.11.0 by kyntk · Pull Request #22 · increments/camo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Bump node from 18.17.1 to 20.11.0 #22

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Bump node from 18.17.1 to 20.11.0 #22

merged 2 commits into from
Feb 9, 2024

Conversation

kyntk
Copy link
@kyntk kyntk commented Feb 8, 2024 •
edited
Loading

What

  • Bump node from 18.17.1 to 20.11.0.
  • Fix rack response

@kyntk kyntk mentioned this pull request Feb 8, 2024
Closed
@kyntk kyntk force-pushed the docker/node-20.11.0 branch 2 times, most recently from b80bf73 to 0cc4d2e Compare February 9, 2024 05:09
kyntk
kyntk commented Feb 9, 2024
View reviewed changes
server.coffee
@@ -194,7 +194,7 @@ process_url = (url, transferredHeaders, resp, remaining_redirects) ->
# decode a string of two char hex digits
hexdec = (str) ->
if str and str.length > 0 and str.length % 2 == 0 and not str.match(/[^0-9a-f]/)
buf = new Buffer(str.length / 2)
buf = new Buffer.alloc(str.length / 2)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this error

DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

@kyntk kyntk force-pushed the docker/node-20.11.0 branch from 0cc4d2e to f5e6534 Compare February 9, 2024 05:17
@kyntk kyntk self-assigned this Feb 9, 2024
@kyntk kyntk requested review from a team and atm-snag2 and removed request for a team February 9, 2024 05:20
atm-snag2
atm-snag2 reviewed Feb 9, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -3,6 +3,8 @@ Unreleased

<!-- Add descriptions of changes here -->

* Add support for Node v20 and drop support for Node v17 [22](https://github.com/increments/camo/pull/22)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe

Suggested change
* Add support for Node v20 and drop support for Node v17 [22](https://github.com/increments/camo/pull/22)
* Add support for Node v20 and drop support for Node v17 or before [22](https://github.com/increments/camo/pull/22)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atm-snag2
Thanks! I fixed it 👍

@kyntk kyntk force-pushed the docker/node-20.11.0 branch from f5e6534 to 63eb30f Compare February 9, 2024 05:36
atm-snag2
atm-snag2 approved these changes Feb 9, 2024
View reviewed changes
Copy link
@atm-snag2 atm-snag2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyntk kyntk merged commit 9e76eb0 into master Feb 9, 2024
@kyntk kyntk deleted the docker/node-20.11.0 branch February 9, 2024 07:14
@kyntk kyntk mentioned this pull request Feb 9, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atm-snag2 atm-snag2 atm-snag2 approved these changes

Assignees

@kyntk kyntk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyntk @atm-snag2
0