Fixing function %||% not being found #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grst
suggested changes
Sep 6, 2021
Comment on lines
+10
to
+14
| #ifdef RCPP_USE_GLOBAL_ROSTREAM | ||
| Rcpp::Rostream<true>& Rcpp::Rcout = Rcpp::Rcpp_cout_get(); | ||
| Rcpp::Rostream<false>& Rcpp::Rcerr = Rcpp::Rcpp_cerr_get(); | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Where does this change come from? Has it been added by roxygen?
There was a problem hiding this comment.
yes, it has. I am unsure whether it is necessary though
Update DESCRIPTION
mumichae
added a commit
to theislab/scib-pipeline
that referenced
this pull request
Mar 3, 2022
LuckyMD
pushed a commit
to theislab/scib-pipeline
that referenced
this pull request
Mar 3, 2022
* update scib package name * fix batch variable check between integrated and nonintegraed adata * update environments to correct scib versions * using pip version of scib * fix R import issue for Harmony (as mentioned in immunogenomics/harmony#134) * use value counts to check for batch relabeling after integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using harmony with the package CDSeq (https://github.com/kkang7/CDSeq_R_Package), I discovered tha 8000 t I always got this error:
This error will not be there if
library(rlang)is called before, but that can't always be guaranteed. The issue can be fixed by including an @importFrom for '%||%' and 'DefaultAssay' in the RunHarmony methods