10000 Various build fixes and improvements by chewi · Pull Request #10 · immobiliare/sfs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Various build fixes and improvements #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Various build fixes and improvements #10

wants to merge 6 commits into from

Conversation

chewi
Copy link
@chewi chewi commented Oct 13, 2017

I'd like to package this for Gentoo Linux once I get it working.

chewi added 6 commits October 11, 2017 23:19
@chewi
Make -Werror a debug compiler flag
45aaf1f 
Though well-intentioned, -Werror can be a source of headaches for
downstream users and distros. GCC tends to become stricter over time.
@chewi
Respect user-provided CFLAGS and LDFLAGS
6d2ed28 
This is important for some distros.
@chewi
Don't call pkg-config more than necessary during the build
663a6e3
@chewi
Don't use CFLAGS for C++ code
1891fb4 
It is standard practise to use CXXFLAGS here.
@chewi
Use CC and CXX variables rather than hardcoding gcc and g++
5ce357b 
This is particularly important for cross-compiling.
@chewi
Fix whitespace to squash GCC 7.2.0 warnings
2618d07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chewi
0