8000 bugfixes: added await for fileWrites (was hanging), added path import, url escape issue by bcliden · Pull Request #58 · imfunniee/gitfolio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 19, 2022. It is now read-only.

bugfixes: added await for fileWrites (was hanging), added path import, url escape issue #58

Merged
merged 3 commits into from
May 26, 2019
8000

Conversation

bcliden
Copy link
Contributor
@bcliden bcliden commented May 24, 2019
  • added await for both async file writes @ populate.js

the build command would hang at the end whenever I ran it. added await to ensure the writes finish.
these could also be crammed in a Promise.all, but it's probably not necessary...

  • added missing path import @ run.js
  • fixed background image link being escaped by hbs (any query strings were being mangled) @ theme files
  • slight syntax tweak in buildCommand for consistency @ build.js
  • added params to url, letting unsplash do the cropping etc. only 90kb file to load now 👍

🚀

@bcliden bcliden changed the title added await for fileWrites (was hanging), added path import bugfixes: added await for fileWrites (was hanging), added path import, url escape issue May 24, 2019
@imfunniee imfunniee merged commit 17cd853 into imfunniee:master May 26, 2019
@bcliden bcliden deleted the path+await branch May 27, 2019 14:38
niradler pushed a commit to niradler/gitfolio that referenced this pull request Jun 24, 2020
* Update README.md

* Create FUNDING.yml

* Update README.md

* Update FUNDING.yml

* fail to run bug fix (imfunniee#62)

* added link to GH profile in username block + styling (imfunniee#59)

* bugfixes: added await for fileWrites (was hanging), added path import, url escape issue (imfunniee#58)

* added await for fileWrites (was hanging), added path import

* fixed html escaping issue with background image. +consistency

* changed default background to smaller params. only 90kb

* v.0.1.4

* Delete FUNDING.yml

* Horizontal ordering of Repos + Forks (imfunniee#66)

* decent grid layout. some weird gutter issue tho

* added neg margin to align with headings. fix a elem width.

* quick fix for single-column error when screen is very wide

* docs: add URL with port number to preview the website (imfunniee#69)

* Delete index.css

* Add files via upload

* fixed css for project + fork rows and some other (imfunniee#71)

* Fixes imfunniee#73 (imfunniee#74)

Fixes blog entry URLs with custom folder names.

* Bump lodash from 4.17.11 to 4.17.14 (imfunniee#83)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.14)

Signed-off-by: dependabot[bot] <support@github.com>

* Added Handles for Twitter, Linkedin and Medium to GitFolio (imfunniee#84)

* Added Handles for Twitter, Linkedin and Medium to GitFolio

* Updates README

* Updates README

* Add files via upload

* Delete blog.js

* Add files via upload

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* update 0.1.5

-added UI
-fixed bugs
-fixed css issues
-creating a blog is now easier than ever

* Delete index.css

* Delete Circular.otf

* Delete index.js

* Update README.md

* Fixed Issues and added a UI

* Update README.md

* remove host workaround for emoji URLs since github-emoji v1.1.1 fixed it (imfunniee#94)

* Setting line endings to unix-style (imfunniee#95)

* Add gitattributes settings to LF
* TY @Pliavi 
* Converting all CRLF to LF

Co-authored-by: imfunny <36105478+imfunniee@users.noreply.github.com>
Co-authored-by: yrong1997 <yrong1997@gmail.com>
Co-authored-by: Benjamin Liden <benjamin.c.liden@gmail.com>
Co-authored-by: Gianfrancø Palumbo <gianpa@gmail.com>
Co-authored-by: traxam <tr808axm@hotmail.de>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rohan Mohapatra <31756343+rohanmohapatra@users.noreply.github.com>
Co-authored-by: Linda_pp <rhysd@users.noreply.github.com>
Co-authored-by: Vitor "Pliavi" Silvério <Pliavi.rpgm@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0