Add Video thumbnail tile option #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Video Thumbnail Tile option, providing type definitions, build logic, and tests to generate tiled video sprites.
- Introduces new type definitions and options for video thumbnail tiles.
- Implements a build function that constructs the option string with configurable flags and focus coordinates.
- Adds comprehensive tests and updates the Options type for integration.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/optionsBasic/videoThumbnailTile.test.ts | New tests validating video thumbnail tile option behavior. |
| src/types/videoThumbnailTile.ts | New type definitions for the video thumbnail tile option. |
| src/types/index.ts | Updates to include the new video thumbnail tile types. |
| src/options/videoThumbnailTile.ts | Implements option detection and string building for video thumbnail tiles. |
| src/options/index.ts | Exports the new video thumbnail tile option module. |
| .changeset/moody-coins-wink.md | Adds a changeset note for the new feature. |
Comments suppressed due to low confidence (2)
src/options/videoThumbnailTile.ts:14
- [nitpick] The error message key 'video_thumbnail_tile' may be misleading when the option is provided via the 'vtt' shorthand. Consider updating the error messaging to dynamically reflect the actual key used.
guardIsUndef(vtt, "video_thumbnail_tile");
src/options/videoThumbnailTile.ts:16
- [nitpick] Similar to the previous comment, the error message here uses 'video_thumbnail_tile.step' even when the shorthand 'vtt' is used. Consider aligning the error references with the input key to reduce potential confusion.
guardIsNotNum(vtt.step, "video_thumbnail_tile.step");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10