cmake: fix build with cmake 4.0.0 #47

tgurr · 2025-05-13T14:36:43Z

Fixes CMake >= 4.0.0 build failure:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

lgritz

I believe this is fine as it stands.

Though the CI run reveals that, unrelated to this PR, our CI has rusted away a bit and is failing because the GHA runners themselves have broken things. We need to update the CI workflow, much like we did for other projects a couple months back, to do the trick to make the right npm still work with the old ASWF images (or just switch to newer images).

cmake: fix build with cmake 4.0.0

e5df7dd

lgritz approved these changes May 14, 2025

View reviewed changes

grdanny merged commit f7cdd17 into imageworks:master May 14, 2025
6 of 25 checks passed

tgurr deleted the cmake-4.0 branch May 14, 2025 07:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmake: fix build with cmake 4.0.0 #47

cmake: fix build with cmake 4.0.0 #47

cmake: fix build with cmake 4.0.0 #47

cmake: fix build with cmake 4.0.0 #47

Conversation

Choose a reason for hiding this comment