8000 Show OSD for loop status change when related option changes by uiryuu · Pull Request #5055 · iina/iina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Show OSD for loop status change when related option changes #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

Show OSD for loop status change when related option changes #5055

merged 1 commit into from
Jul 10, 2024

Conversation

uiryuu
Copy link
Member
@uiryuu uiryuu commented Jul 8, 2024

Description:
Listen to MPVOption.PlaybackControl.loopFile and MPVOption.PlaybackControl.loopPlaylist to display OSDs for loop status changes.

@uiryuu uiryuu linked an issue Jul 8, 2024 that may be closed by this pull request
File loop keybinding not working in current version #4841
Closed
low-batt
low-batt approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor
@low-batt low-batt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled PR, built IINA, tested key bindings. OSD and button in playlist worked fine. Changes look good to me.

@uiryuu uiryuu merged commit 0ababb4 into develop Jul 10, 2024
1 check passed
@uiryuu uiryuu deleted the show-loop-osd branch July 10, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@low-batt low-batt low-batt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File loop keybinding not working in current version
2 participants
@uiryuu @low-batt
0