Fix order of filter parameters is random, #4262 #4263
Conversation
This commit will: - Add a new struct FilterParameters that holds parameters in a KeyValuePairs object - Change FilterPreset to use the new struct to preserve the order of parameters specified in the filter definition This insures the order of the UI controls displayed to the user representing the filter parameters remains consistent.
| /// instead of a Swift dictionary to hold the name to `FilterParameter` mapping. The order of the parameters dictates the order | ||
| /// of the UI controls displayed to the user. A dictionary **must not** be used as that would cause the UI controls representing the | ||
| /// parameters to appear in random order. | ||
| struct FilterParameters { |
There was a problem hiding this comment.
Why should we create a new struct for this? I think we can directly use KeyValuePairs<String, FilterParameter> for FilterPreset.params. For the .get() method, we can implement in the extension of KeyValuePairs
There was a problem hiding this comment.
I was trying to make it really clear how filter parameters must be contained to avoid people using dictionaries. I'll go ahead and simplify and use KeyValuePairs inline.
There was a problem hiding this comment.
Not possible to implement the get method as an extension to KeyValuePairs because the Key generic parameter is not defined as being equatable. No matter. The approach I used is totally and completely wrong. I missed that there is already a paramOrder. But is it optional and missing from several presets. I'm closing this PR and opening a new one that uses the existing system for ordering parameters.
|
Replaced by PR #4407. |
This commit will:
This insures the order of the UI controls displayed to the user representing the filter parameters remains consistent.
Description: