Low batt fix 3405 #3699
Merged
Low batt fix 3405 #3699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - Changes cachedVideoDurationAndProgress and cachedMetadata to be private to the PlaybackInfo class. - Adds a private DispatchQueue named lockQueue to coordinate thread access to the cache - Adds methods for operating on the cache dictionaries that use lockQueue to single thread the operations - Dedicates the DispatchQueue playlistQueue to background tasks This corrects a problem where the main thread is blocked waiting for a background task to finish.
1 task
lhc70000
added a commit
that referenced
this pull request
Apr 24, 2022
* Fix deadlock in PlaylistViewController, #3405 This commit: - Changes cachedVideoDurationAndProgress and cachedMetadata to be private to the PlaybackInfo class. - Adds a private DispatchQueue named lockQueue to coordinate thread access to the cache - Adds methods for operating on the cache dictionaries that use lockQueue to single thread the operations - Dedicates the DispatchQueue playlistQueue to background tasks This corrects a problem where the main thread is blocked waiting for a background task to finish. * Add missing getCachedVideoDurationAndProgress Co-authored-by: low-batt <86170219+low-batt@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is from #3479. The code in the previous PR won't compile and I added a missing method call.
It fixes issue #3405.