8000 Fix NSInvalidArgumentException crash, #3584 by low-batt · Pull Request #3588 · iina/iina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix NSInvalidArgumentException crash, #3584 #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? 8000 Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2022
Merged

Fix NSInvalidArgumentException crash, #3584 #3588

merged 1 commit into from
Apr 30, 2022

Conversation

low-batt
Copy link
Contributor

The commit in the pull request corrects a crash due to a
NSInvalidArgumentException being thrown by the
NowPlayingInfoManager.updateInfo method as a result of multiple threads
changing the same dictionary at the same time. The commit updates the
NowPlayingInfoManager class to be thread safe.

Description:

@lhc70000
Copy link
Member

There's a conflict after merging #3579. Could you please rebase the code?

@low-batt
Fix NSInvalidArgumentException crash, iina#3584
39ed0f7 
The commit in the pull request corrects a crash due to a
NSInvalidArgumentException being thrown by the
NowPlayingInfoManager.updateInfo method as a result of multiple threads
changing the same dictionary at the same time. The commit updates the
NowPlayingInfoManager class to be thread safe.
@low-batt
Copy link
Contributor Author

Rebased.

@lhc70000 lhc70000 merged commit 9756796 into iina:develop Apr 30, 2022
@low-batt low-batt mentioned this pull request Apr 30, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@low-batt @lhc70000
0