8000 Playback history window doesn't respect reduce motion · Issue #4870 · iina/iina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Playback history window doesn't respect reduce motion #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
low-batt opened this issue Apr 7, 2024 · 0 comments · Fixed by #4871
Closed
1 task done

Playback history window doesn't respect reduce motion #4870

low-batt opened this issue Apr 7, 2024 · 0 comments · Fixed by #4871
Assignees
@low-batt
Labels
bug: hig Human Interface Guidelines Deviation feature: ui/ux progress: fixed/implemented

Comments

@low-batt
Copy link
Contributor
low-batt commented Apr 7, 2024

System and IINA version:

  • macOS 13.6.3
  • IINA 1.3.4

Expected behavior:
IINA reduces animations if the user has enabled the macOS Reduce motion setting. From Apple's Human Interface Guidelines section Motion:

Play tightened animations when Reduce Motion is on. People can turn on Reduce Motion if they tend to get distracted or experience dizziness or nausea when viewing animations that include effects such as zooming, scaling, spinning, or peripheral motion. In response to this setting, you need to turn off or reduce animations that are known to cause problems (to learn more, see Responsive Design for Motion).

Actual behavior:
Disclosure triangles in the Playback History window use a sliding animation when showing and hiding information.

Steps to reproduce:

  • Start IINA

  • Click on Playback History under the File menu

  • The Playback History window appears

  • Click on the triangle next to one of the dates

  • The nested list of videos played on that date collapses into the date with a sliding animation

  • MPV does not have this problem.

How often does this happen?
Every time.
@low-batt low-batt added feature: ui/ux bug: hig Human Interface Guidelines Deviation labels Apr 7, 2024
@low-batt low-batt self-assigned this Apr 7, 2024
low-batt added a commit that referenced this issue Apr 7, 2024
@low-batt
Fix playback history window doesn't respect reduce motion, #4870
5519589 
This commit will:
- Add a new class OutlineView that extends NSOutlineView adding support
  for reducing motion
- Change HistoryWindowController.xib to use OutlineView instead of
  NSOutlineView

This suppresses the sliding animation when collapsing and expanding
rows in the playback history window.
@low-batt low-batt mentioned this issue Apr 7, 2024
Merged
2 tasks
@low-batt low-batt linked a pull request Apr 7, 2024 that will close this issue
Fix playback history window doesn't respect reduce motion, #4870 #4871
Merged
2 tasks
low-batt added a commit that referenced this issue May 13, 2024
@low-batt
Fix playback history window doesn't respect reduce motion, #4870
3a08b3b 
This commit will change IINA to adhere to the Apple Human Interface
Guidelines with respects to the macOS "Reduce motion" setting. With
these changes IINA will reduce, not eliminate, animations when the macOS
reduce motion setting is enabled. When this setting is enabled IINA will
fade in the sidebar instead of sliding it into view. All other changes
to animation behavior, such as how IINA transitions in and out of full
screen mode, are provide by AppKit.

For users who are hyper sensitive to motion this commit adds an
"Enable animations" setting to the UI settings tab in a new "Animations"
section at the bottom of the panel. Disabling this setting will
eliminate many, but not all, animated transition effects.
low-batt added a commit that referenced this issue May 13, 2024
@low-batt
Fix playback history window doesn't respect reduce motion, #4870
5a34bdb 
This commit will change IINA to adhere to the Apple Human Interface
Guidelines with respects to the macOS "Reduce motion" setting. With
these changes IINA will reduce, not eliminate, animations when the macOS
reduce motion setting is enabled. When this setting is enabled IINA will
fade in the sidebar instead of sliding it into view. All other changes
to animation behavior, such as how IINA transitions in and out of full
screen mode, are provide by AppKit.

For users who are hyper sensitive to motion this commit adds an
"Enable animations" setting to the UI settings tab in a new "Animations"
section at the bottom of the panel. Disabling this setting will
eliminate many, but not all, animated transition effects.
low-batt added a commit that referenced this issue May 26, 2024
@low-batt
Fix playback history window doesn't respect reduce motion, #4870
b68df40 
This commit will change IINA to adhere to the Apple Human Interface
Guidelines with respects to the macOS "Reduce motion" setting. With
these changes IINA will reduce, not eliminate, animations when the macOS
reduce motion setting is enabled. When this setting is enabled IINA will
fade in the sidebar instead of sliding it into view. All other changes
to animation behavior, such as how IINA transitions in and out of full
screen mode, are provide by AppKit.

For users who are hyper sensitive to motion this commit adds an
"Disable animations" setting to the UI settings tab in a new
"Accessibility" section at the bottom of the panel. Enabling this
setting will eliminate many, but not all, animated transition effects.
low-batt added a commit that referenced this issue May 26, 2024
@low-batt
Fix playback history window doesn't respect reduce motion, #4870
7d00f6c 
This commit will change IINA to adhere to the Apple Human Interface
Guidelines with respects to the macOS "Reduce motion" setting. With
these changes IINA will reduce, not eliminate, animations when the macOS
reduce motion setting is enabled. When this setting is enabled IINA will
fade in the sidebar instead of sliding it into view. All other changes
to animation behavior, such as how IINA transitions in and out of full
screen mode, are provide by AppKit.

For users who are hyper sensitive to motion this commit adds an
"Disable animations" setting to the UI settings tab in a new
"Accessibility" section at the bottom of the panel. Enabling this
setting will eliminate many, but not all, animated transition effects.
uiryuu pushed a commit that referenced this issue May 28, 2024
@low-batt
Fix playback history window doesn't respect reduce motion, #4870 (#4871)
bcb5c2b 
* Fix playback history window doesn't respect reduce motion, #4870

This commit will:
- Add a new class OutlineView that extends NSOutlineView adding support
  for reducing motion
- Change HistoryWindowController.xib to use OutlineView instead of
  NSOutlineView

This suppresses the sliding animation when collapsing and expanding
rows in the playback history window.

* Fix playback history window doesn't respect reduce motion, #4870

This commit will change IINA to adhere to the Apple Human Interface
Guidelines with respects to the macOS "Reduce motion" setting. With
these changes IINA will reduce, not eliminate, animations when the macOS
reduce motion setting is enabled. When this setting is enabled IINA will
fade in the sidebar instead of sliding it into view. All other changes
to animation behavior, such as how IINA transitions in and out of full
screen mode, are provide by AppKit.

For users who are hyper sensitive to motion this commit adds an
"Enable animations" setting to the UI settings tab in a new "Animations"
section at the bottom of the panel. Disabling this setting will
eliminate many, but not all, animated transition effects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
bug: hig Human Interface Guidelines Deviation feature: ui/ux progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix playback history window doesn't respect reduce motion, #4870 iina/iina
1 participant
@low-batt
0