8000 Pressing arrow keys to move the cursor in some input fields affects playback · Issue #4583 · iina/iina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pressing arrow keys to move the cursor in some input fields affects playback #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rasitayaz opened this issue Aug 14, 2023 · 9 comments · Fixed by #4590
Closed

Pressing arrow keys to move the cursor in some input fields affects playback #4583

rasitayaz opened this issue Aug 14, 2023 · 9 comments · Fixed by #4590
Assignees
@svobs
Labels
bug progress: fixed/implemented

Comments

@rasitayaz
Copy link
rasitayaz commented Aug 14, 2023 •
edited
Loading

In "save downloaded subtitle" dialog, pressing arrow keys to move the cursor in filename input affects playback.

System and IINA version:

  • macOS Ventura 13.4
  • IINA 1.3.3 Build 138

Expected behavior:

Video duration to stay the same

Actual behavior:

Video rewinds when pressed left arrow key to move the cursor inside input field, fast forwards when pressed right arrow key, just like they normally do in playback window.

Steps to reproduce:

Download an online subtitle, open "save download subtitle" dialog, try to move the cursor in filename field with arrow keys.

How often does this happen?

All the time
@rasitayaz
Copy link
Author
rasitayaz commented Aug 14, 2023 •
edited
Loading

Seems like this issue is not just related to "save downloaded subtitle" screen: #3206, #3039

@rasitayaz rasitayaz changed the title Pressing left and right arrow keys to move the cursor in filename input while saving downloaded subtitle causing video to rewind and fast forward Pressing arrow keys to move the cursor in filename input while saving downloaded subtitle affects playback Aug 14, 2023
@rasitayaz rasitayaz changed the title Pressing arrow keys to move the cursor in filename input while saving downloaded subtitle affects playback Pressing arrow keys to move the cursor in some input fields affects playback Aug 14, 2023
@low-batt
Copy link
Contributor

Thank you for reporting this. Extra thanks for pointing out there are similar problems with other input fields as reported in the cited issues.

@svobs Another issue related to processing key strokes. This one is not a recent regression.

@low-batt low-batt added the bug label Aug 14, 2023
@svobs
Copy link
Contributor
svobs commented Aug 17, 2023

I already found a partial fix. See #4587, which should address the Quick Settings fields.

Unfortunately it looks like a separate fix will be required for Open/Save dialogs.

@svobs svobs mentioned this issue Aug 17, 2023
Merged
2 tasks
@low-batt low-batt linked a pull request Aug 18, 2023 that will close this issue
Make open/save dialogs block window input while open (fixes #4583) #4590
Merged
2 tasks
@svobs
Copy link
Contributor
svobs commented Oct 9, 2023

The PR for this fix may is no longer necessary. Apple has fixed this problem from their end.

From the Sonoma release notes:

Modeless and applic 8000 ation modal open and save panels are now main windows. (14623155, 103038843)
 This fixes a problem where menu items that weren’t applicable to the open or save panel remained enabled.
Open and save panels that are displayed as sheets are unchanged.

I downloaded and ran the latest nightly build, which confirmed this - at least for Sonoma.

@low-batt
Copy link
Contributor
low-batt commented Oct 9, 2023

Not sure how much that helps? We still need to fix this for older macOS versions. Even though I find it annoying the change that ties the sheet to the window is probably correct as it matching up with how save dialogs for Apple applications work.

@svobs
Copy link
Contributor
svobs commented Oct 9, 2023

Not sure how much that helps? We still need to fix this for older macOS versions. Even though I find it annoying the change that ties the sheet to the window is probably correct as it matching up with how save dialogs for Apple applications work.

That is a fair point... and the modal nature of the sheet does clean up the control flow by preventing the user from altering any of the state on which the dialog relies. I won't close the PR.

@low-batt
Copy link
Contributor

Sounds good. We will see what the other developers opinion is on this. I'm hoping they will free up in another week and be able to review and merge some of these PRs.

uiryuu pushed a commit that referenced this issue Jan 2, 2024
@svobs
Make open/save dialogs block window input while open (fixes #4583) (#…
ac6d17c 
…4590)

* Attach the following open/save dialogs to parent windows so that arrow key navigation works inside them instead of activating menu items: (1) "Load external audio file", (2) "Load external subtitle" (Subtitles menu), (3) "Load subtitle..." (Quick Settings button), (4) "Save downloaded subtitle" (Subtitles menu)

* Make Save Playlist dialog into a sheet
@low-batt
Copy link
Contributor
low-batt commented Jan 2, 2024

The fix for this issue has been merged into the IINA develop branch. GitHub automatically closed the linked issue in reaction to the merge. I am reopening this issue until the fix is available in an official release of IINA so that users intending to report this problem can easily locate this existing report. Once the fix for this issue has been included in an official release this issue will be closed.

@low-batt low-batt reopened this Jan 2, 2024
@low-batt
Copy link
Contributor
low-batt commented Jun 9, 2024

This was fixed in IINA 1.3.5.

@low-batt low-batt closed this as completed Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svobs svobs

Labels
bug progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make open/save dialogs block window input while open (fixes #4583) svobs/iina-advance
3 participants
@svobs @rasitayaz @low-batt
0