8000 File Loop menu item does not show ✔︎ when toggled on · Issue #3625 · iina/iina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

File Loop menu item does not show ✔︎ when toggled on #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vassudanagunta opened this issue Jan 27, 2022 · 3 comments
Closed

File Loop menu item does not show ✔︎ when toggled on #3625

vassudanagunta opened this issue Jan 27, 2022 · 3 comments
Labels
progress: fixed/implemented

Comments

@vassudanagunta
Copy link
vassudanagunta commented Jan 27, 2022 •
edited
Loading

System and IINA version:

  • macOS 12.1
  • IINA 1.2.0 build 129

Expected behavior:

When File Loop playback mode is enabled, the File Loop menu item should have a ✔︎ to show that it is on -- just like Playlist Loop menu item.

Actual behavior:
No ✔︎ ever appears.
@vassudanagunta vassudanagunta mentioned this issue Jan 27, 2022
Closed
@low-batt
Copy link
Contributor

Reproduced for me. This is a defect.

IINA code is treating the mpv loop-file property as a boolean flag. It is not a boolean. That is the source of these problems. This is the definition of the property from the mpv manual:

--loop-file=<N|inf|no>, --loop=<N|inf|no>
   Loop a single file N times. inf means forever, no means normal playback.

@CarterLi has a fix for this. He is currently away. I will coordinate with him when he gets back.

This was referenced Apr 24, 2022
Closed
Merged
CarterLi added a commit to CarterLi/iina that referenced this issue Apr 28, 2022
@CarterLi
PlaylistView: Fix loop* issues
559f650 
1. Store preference for playlist loop status
2. Make `loop file` actually work and add a `loop file` button

Fix iina#3625 and iina#3626

TODO: The style of the new `loop file` button in active mode doesn't
match other buttons in playlist view, which needs rework

Related PR: iina#3700
@CarterLi CarterLi mentioned this issu 8000 e Apr 28, 2022
Merged
2 tasks
CarterLi added a commit to CarterLi/iina that referenced this issue Apr 29, 2022
@CarterLi
PlaylistView: Fix loop* issues
2adeea7 
1. Store preference for playlist loop status
2. Make `loop file` actually work and add a `loop file` button

Fix iina#3625 and iina#3626

TODO: The style of the new `loop file` button in active mode doesn't
match other buttons in playlist view, which needs rework

Related PR: iina#3700
CarterLi added a commit to CarterLi/iina that referenced this issue Apr 30, 2022
@CarterLi
PlaylistView: Make loop file actually work and add a loop file bu…
b79baa8 
…tton

Fix iina#3625 and iina#3626

TODO: The style of the new `loop file` button in active mode doesn't
match other buttons in playlist view, which needs rework

Related PR: iina#3700
@low-batt
Copy link
Contributor
low-batt commented May 9, 2022

Fix has been merged into the develop branch.

@low-batt
Copy link
Contributor

Closing. Fixed in IINA 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vassudanagunta @low-batt
0