8000 Adventure map, animation and hero centering on adventure map with interaction of object that displays a window · Issue #6965 · ihhub/fheroes2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adventure map, animation and hero centering on adventure map with interaction of object that displays a window #6965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
LeHerosInconnu opened this issue Apr 8, 2023 · 3 comments · May be fixed by #9779
Open
2 tasks done
Labels
bug Something doesn't work ui UI/GUI related stuff
Milestone

Comments

@LeHerosInconnu
Copy link

Preliminary checks

Platform

Windows

Describe the bug

In fheroes2, when the hero interacts with objects that open a message window, the window is opened just before the hero is centered on the adventure map.
The hero should finish his movement animation and be centered on the adventure map before the message window is displayed.

In fheroes2:
In the example, with Faerie Ring:

2023-04-08.19-29-40.mp4

Open the two images in different tabs in your browser, and switch between the two tabs alternately.
Shotcut_00_00_05_960
Shotcut_00_00_06_000

Save file

Here is the save file:
Before faerie ring 01.zip

Additional info

No response

@LeHerosInconnu LeHerosInconnu added the bug Something doesn't work label Apr 8, 2023
@oleg-derevenetz
Copy link
Collaborator

the window is opened just before the hero is centered on the adventure map.

In fact, the window is opened AFTER the new hero's position is centered on the adventure map (that's what these screenshots demonstrate). But the hero's movement animation is not indeed finished at that time.

@oleg-derevenetz oleg-derevenetz added the ui UI/GUI related stuff label Apr 8, 2023
@oleg-derevenetz oleg-derevenetz added this to the 1.0.4 milestone Apr 8, 2023
@LeHerosInconnu
Copy link
Author

Hello @oleg-derevenetz,

the window is opened just before the hero is centered on the adventure map.

In fact, the window is opened AFTER the new hero's position is centered on the adventure map (that's what these screenshots demonstrate). But the hero's movement animation is not indeed finished at that time.

I don't know what exactly is happening on the programming side, but visually that's the impression you get. :)

@oleg-derevenetz
Copy link
Collaborator

I don't know what exactly is happening on the programming side, but visually that's the impression you get. :)

I mean that at the moment when dialog window appears, adventure map is already centered at the new hero position, that's why the adventure map content is shifted to the right (in the direction opposite to the direction of the hero's movement) on your second screenshot. So the window is opened AFTER the new position of a hero is centered on the adventure map, not BEFORE :)

@ihhub ihhub modified the milestones: 1.0.4, 1.0.5 May 13, 2023
@ihhub ihhub modified the milestones: 1.0.5, 1.0.6 Jun 14, 2023
@ihhub ihhub modified the milestones: 1.0.6, 1.0.7 Jul 15, 2023
@ihhub ihhub modified the milestones: 1.0.7, 1.0.8 Aug 14, 2023
@ihhub ihhub modified the milestones: 1.0.8, 1.0.9 Sep 11, 2023
@ihhub ihhub modified the milestones: 1.0.9, 1.1.0 Oct 11, 2023
@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 May 22, 2024
@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
@ihhub ihhub modified the milestones: 1.1.2, 1.1.3 Sep 15, 2024
@ihhub ihhub modified the milestones: 1.1.3, 1.1.4 Oct 23, 2024
@ihhub ihhub modified the milestones: 1.1.4, 1.1.5 Nov 27, 2024
@ihhub ihhub modified the milestones: 1.1.5, 1.1.6 Dec 30, 2024
@ihhub ihhub modified the milestones: 1.1.6, 1.1.7 Feb 16, 2025
@ihhub ihhub modified the milestones: 1.1.7, 1.1.8 Mar 23, 2025
@ihhub ihhub modified the milestones: 1.1.8, 1.1.9 May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
0