Add option to not fill the entire screen, only the amount of pixels of the selected resolution AKA pixel perfect mode #6612
Comments
|
Hi @zenseii , is this issue still valid after the latest resolution changes? |
|
Hi, @ihhub. It has indeed been fixed with the latest resolution changes. I'm not sure which one it is, for later reference, but now I can select 640x512 (x2.0) and this gives perfectly square pixels by adding borders above and below the image. It should be noted that people should use the "nearest" filtering mode to achieve unblurred pixels, and this is only available thru the config file fheroes2.cfg. We should maybe open a separate issue/discussion about whether we should always add borders to the side as well for resolutions like the one shown above. I'm not sure if this is even possible. |
|
The only point still standing from my OP is about adding the option to switch between filters in the options, instead of having it locked behind fheroes2.cfg. All the other points have been solved. |
|
Actually, I looked closer and it seems the issue about square pixels isn't solved. If you look closely at my picture above you can spot both horizontal and vertical pixels that aren't square when using 640x512 (x2.0): x-directionAnd this line is 3 pixels tall (y-direction) instead of 2: y-directionMeanwhile I noticed that when in windowed mode the pixels are perfectly square. The solution for a screen with a resolution of 1920x1080 px is to have the resolution of "640x480 (x2.0)" together with vertical borders above and below with each a height of 60 px so that you get 480 * 2 + 60 + 60 = 1080. Currently for me 640x480 (x2.0) produces a stretched image without borders: Click for 640x480 (x2.0) image |
|
I went and simply added the resolution of 640x540 in my Intel GPU driver settings (this laptop has intel iGPU with Nvidia dGPU) and lo and behold I was able to get perfect square pixels with borders that are 60px wide: In other words I needed the resolution that was 640 x (480 + 30 + 30) = 540, which becomes 1280x1080 when multiplied by 2. |
|
Here are some additional notes:
The Sword's blade makes it pretty obvious (640x540 to the left, 960x540 to the right): I've highlighted this in the Q from the quit button using nearest filtering: Q letterPixel perfect 640x540 with borders above and below the background:
EDIT: Actually the Credits suffer from this too since they are stretched. Take a look at the fheroes2 engine text: Credits textPixel perfect 640x540: Stretched 960x540 (2.0x and not): |
Preliminary checks
Describe the problem requiring a solution
We should consider adding the possibility to not stretch the image to fill the screen in the vertical direction too. Currently if you select 1280x960 in fullscreen mode on a 1920x1080 screen the image will be stretched to fill the entire height of the screen, instead of leaving two horizontal borders of 120/2 px above and below the image. Please correct me if I'm wrong about this @oleg-derevenetz.
Now that we have integer scaling available I believe it makes sense to have such a "pixel perfect" mode available so that the users who want to can have the sharpest image possible with no stretching/non-integer upscaling. I realize some of this might be dependent on the gpu driver options?
A similar example is how the campaign videos are kept in the original resolution without stretching/upscaling when you have a higher resolution than 640x480 selected. Ideally it should be possible to have these videos upscaled too to match the selected resolution, this might be another issue all together.
If anything I think we should figure out how to make the current image options and the future ones as simple and as easy to understand for the users as possible.
Relates to #5373 and #6516 and #6586 (comment)
Describe the possible solution
Points:
Additional info
No response
The text was updated successfully, but these errors were encountered: