10000 Adventure map, the position of some Stone Liths changes when an AI hero uses them · Issue #4141 · ihhub/fheroes2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adventure map, the position of some Stone Liths changes when an AI hero uses them #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
LeHerosInconnu opened this issue Sep 3, 2021 · 5 comments · May be fixed by #9778
Open
2 tasks done

Adventure map, the position of some Stone Liths changes when an AI hero uses them #4141

LeHerosInconnu opened this issue Sep 3, 2021 · 5 comments · May be fixed by #9778
Labels
bug Something doesn't work good first issue Good for newcomers pixel-precision Fine-tuning of UI elements and assets ui UI/GUI related stuff
Milestone
1.1.9

Comments

@LeHerosInconnu
Copy link

Preliminary checks

Platform

Windows

Describe the bug

In fheroes2, the position of some Stone Liths changes when an AI hero uses them.

Set "Enemy Speed" to "6".
End the turn.
When the AI hero uses the rounded Stone Liths the position of the Stone Liths changes.
End the turn twice more to observe the same phenomenon when the AI hero uses the Stone Liths with the double wooden doors.

In fheroes2:

2021-09-03.12-00-05.mp4

Save file

Here is the save file:
Unicorn bottom mountain 02.zip

Additional info

Version 0.9.6 4111
@LeHerosInconnu LeHerosInconnu added the bug Something doesn't work label Sep 3, 2021
@oleg-derevenetz oleg-derevenetz added the ui UI/GUI related stuff label Sep 3, 2021
@oleg-derevenetz oleg-derevenetz added this to the 0.9.8 milestone Sep 3, 2021
@ihhub ihhub added the good first issue Good for newcomers label Sep 4, 2021
@ihhub ihhub modified the milestones: 0.9.8, 0.9.9 Oct 5, 2021
@ihhub ihhub modified the milestones: 0.9.9, 0.9.10 Nov 5, 2021
@LeHerosInconnu
Copy link
Author

Another save for this (0.9.9 4628).
With Stone Liths with the double wooden doors.

In fheroes2:

2021-11-25.12-54-30.mp4

End the turn.

Here is the save file:
Before AI hero stone liths 01.zip

@ihhub ihhub modified the milestones: 0.9.10, 0.9.11 Dec 5, 2021
@ihhub ihhub modified the milestones: 0.9.11, 0.9.12 Dec 23, 2021
@ihhub ihhub modified the milestones: 0.9.12, 0.9.13 Feb 7, 2022
@ihhub ihhub modified the milestones: 0.9.13, 0.9.14 Mar 7, 2022
@LeHerosInconnu LeHerosInconnu mentioned this issue Mar 20, 2022
Open
2 tasks
@W4tu
Copy link
W4tu commented Apr 6, 2022

Hey guys,

I would like to start fixing this bug as my first issue. I might need some help since I didn't contribute anything else yet - neither here nor somewhere else. Although I know how to use git and github (I suppose).

So, for now I have the following questions:

  1. Do I understand it right that the problem occurs on
    Video_1: 2021-09-03 on second 0:10 - The used teleport (stone lith) moves 1 pixel to the right
    Video_2: 2021-11-25 on second 0:12 - The used teleport moves 1 pixel downwards
    The relative position between the hero (avatar) and the teleport is constant. So the hero's position is also moving 1 pixel (downwards/ to the right) when comparing the positions on entrance and exit.

  2. How are the position dependencies implemented? Is the hero's position depending of the teleport's position or is the teleport's position depending on the hero's position? Probably the first variant?

  3. Does this problem occur only when the AI uses the teleports?

  4. Does this problem occur with every teleport on every map or just with some of the teleports on some maps?

  5. Where do you think is the source of this problem? I thought of some possibilities but I don't know how the teleport (or anything else) is positioned in the "game-world" by the game-engine.
    My suggestions:
    4.1 The two teleports (entrance and exit) are positioned on different positions in the map. Then the problem would not only occur when the AI uses the teleport but also when the (real) player uses it.
    4.2 There is more than one teleporter-picture-file. Although then the hero shouldn't have a constant relative position to the teleport. So this option probably is not the problem.
    4.3 There are more possibilities I can think of but it would be helpful to have the second question[s] (2.) answered. This will probably help a lot.

  6. So, Which files might I watch to understand this problem in particular?

I appreciate every help. Thank you very much!
Sincerely,
W4tu

@zenseii
8000
Copy link
Collaborator
zenseii commented Apr 7, 2022

To me it looks like it only happens when the AI exits the portal and not when entering. As for where in the code this is I would have to try to look it up, but hopefully someone more knowledgable will be able to answer you.

@LeHerosInconnu
Copy link
Author

Hello @W4tu and @zenseii,

  1. Does this problem occur only when the AI uses the teleports?

Yes, this bug only affects AI heroes.
There was a similar problem with the human player's heroes and it was fixed (it was easier to spot this bug).

  1. Does this problem occur with every teleport on every map or just with some of the teleports on some maps?

I have not tested on other scenarios, but this problem is certainly valid for all scenarios.

To me it looks like it only happens when the AI exits the portal and not when entering. As for where in the code this is I would have to try to look it up, but hopefully someone more knowledgable will be able to answer you.

Yes, it's the destination Stone Liths that is the problem.

@ihhub ihhub modified the milestones: 0.9.14, 0.9.15 Apr 9, 2022
@ihhub ihhub modified the milestones: 0.9.15, 0.9.16 May 7, 2022
@ihhub ihhub modified the milestones: 0.9.16, 0.9.17 Jun 12, 2022
@ihhub ihhub modified the milestones: 0.9.17, 0.9.18 Jul 11, 2022
@ihhub ihhub removed this from the 0.9.18 milestone Aug 10, 2022
@ihhub ihhub added this to the 1.0.7 milestone Jul 15, 2023
@ihhub ihhub modified the milestones: 1.0.7, 1.0.8 Aug 14, 2023
@ihhub ihhub modified the milestones: 1.0.8, 1.0.9 Sep 11, 2023
@ihhub ihhub modified the milestones: 1.0.9, 1.0.10 Oct 11, 2023
@ihhub ihhub modified the milestones: 1.0.10, 1.0.11 Nov 18, 2023
@ihhub ihhub modified the milestones: 1.0.11, 1.1.0 Dec 23, 2023
@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 May 22, 2024
@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
@ihhub ihhub modified the milestones: 1.1.2, 1.1.3 Sep 15, 2024
@ihhub ihhub modified the milestones: 1.1.3, 1.1.4 Oct 23, 2024
@ihhub ihhub modified the milestones: 1.1.4, 1.1.5 Nov 27, 2024
@ihhub ihhub modified the milestones: 1.1.5, 1.1.6 Dec 30, 2024
@ihhub ihhub modified the milestones: 1.1.6, 1.1.7 Feb 16, 2025
@ihhub ihhub modified the milestones: 1.1.7, 1.1.8 Mar 23, 2025
@Districh-ru Districh-ru linked a pull request May 3, 2025 that will close this issue
Open
@ihhub ihhub modified the milestones: 1.1.8, 1.1.9 May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something doesn't work good first issue Good for newcomers pixel-precision Fine-tuning of UI elements and assets ui UI/GUI related stuff
Projects
None yet
Milestone
1.1.9
Development

Successfully merging a pull request may close this issue.

Fix map center positioning when AI interacts with action object Districh-ru/fheroes2
5 participants
@zenseii @ihhub @oleg-derevenetz @LeHerosInconnu @W4tu
0