🚨 Fix 3.0.5 Android issues #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the latest release (3.0.5), ProGuard was crashing the app during startup. After some investigation, I decided to simply not obfuscate the failing modules since only keeping the offending classes is causing duplication issues. Additional compiler rules were added to stop warning about StringFactory https://issuetracker.google.com/issues/250197571 Lastly, the compiler was upgraded from 1.8 to 11 because the compiler args needs this version.
After fixing the ProGuard issues, a new one appeared. Voyager was complaining that the existing key was being used when clicking in the "add" FAB. Taking a look into the documentation, it's recommended for the screens to have unique ids. Adding it solved the issue.
New version released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last release is working fine on iOS but breaking on Android.