fix: improved fqdn regexp, added restrictions just like in idnits2 #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
approved these changes
Apr 21, 2025
rjsparks
requested changes
Apr 21, 2025
There was a problem hiding this comment.
Revoking the approval from a moment ago - I don't think things are right yet and wonder if there's been a negation somewhere in the reading of the logic of idnits2.
On this branch, for draft-ietf-spring-cs-sr-policy-06.txt, I still see many complaints from idnits3 about, e.g.,
2 Warning
└- Code - INVALID_DOMAIN_TLD
└- Desc - Domain "h.encaps" has an invalid TLD.
└- Ref - https://www.iana.org/domains/root/db
3 Warning
└- Code - INVALID_DOMAIN_TLD
└- Desc - Domain "daniel.voyer" has an invalid TLD.
└- Ref - https://www.iana.org/domains/root/db
e1f1429 to
63a9b9f
Compare
NGPixel
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #88, #138