-
Notifications
You must be signed in to change notification settings - Fork 527
feat: begin supporting the new rfc editor model #3960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3960 +/- ##
==========================================
- Coverage 88.14% 88.14% -0.01%
==========================================
Files 297 297
Lines 39273 39278 +5
==========================================
+ Hits 34618 34620 +2
- Misses 4655 4658 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noe an expert here, but LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Only nit is some copyright notices that haven't been updated.
This has one thing that I don't like, but changing it will be a bigger lift. It exposes what had to date been an internal artifact: the group type name slug of
rfcedtyp
which now shows in the urls when following some of the menus.