fix: refactor/correct calculation of week-view event start/end times #3947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Around DST changes, localize(time + duration).astimezone() is not the same as localize(time).astimezone() + duration. The latter allows tz-aware times to do their magic and give correct clock times.
There were bugs in the timestamp calculations around DST switchover. This corrects those and tries to clarify and improve documentation in the relevant code.
rjsparks
approved these changes
May 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #3947 +/- ##
==========================================
+ Coverage 88.00% 88.14% +0.13%
==========================================
Files 297 297
Lines 38773 39273 +500
==========================================
+ Hits 34123 34618 +495
- Misses 4650 4655 +5
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Around DST switchover dates, the agenda week-view display had some errors in its timestamp calculations. These led to sessions ending at timestamps earlier than when they started. This straightens that out and refactors the code for clarity.
There were also similar bugs in the
TimeSlotlocal and utc start/end time helper functions. These are fixed as well.