8000 feat: Warn if uploading minutes before session end by jimfenton · Pull Request #8700 · ietf-tools/datatracker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Warn if uploading minutes before session end #8700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 2, 2025

Conversation

jimfenton
Copy link
Collaborator
@jimfenton jimfenton commented Mar 19, 2025

Fixes #8640

@jimfenton jimfenton changed the title Warn if uploading minutes before session end feat: Warn if uploading minutes before session end Mar 19, 2025
@rjsparks
Copy link
Member

From discussions with Jim, I'll pick this one up and add tests.

@rjsparks rjsparks self-assigned this Mar 19, 2025
Copy link
codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (70bf2ae) to head (e61a5ca).
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8700      +/-   ##
==========================================
- Coverage   88.88%   88.81%   -0.07%     
==========================================
  Files         312      314       +2     
  Lines       40891    41256     +365     
==========================================
+ Hits        36345    36641     +296     
- Misses       4546     4615      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks
Copy link
Member

@jennifer-richards The github Files changed panel makes more sense if you tell it to ignore whitespace changes.

@rjsparks rjsparks merged commit afa79dc into ietf-tools:main Apr 2, 2025
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it obvious that a meeting hasn't happened yet when trying to upload minutes before the meeting starts
3 participants
0