8000 fix(agenda): handle calendar view events that spread across multiple days by NGPixel · Pull Request #8685 · ietf-tools/datatracker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(agenda): handle calendar view events that spread across multiple days #8685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

fix(agenda): handle calendar view events that spread across multiple days #8685

merged 1 commit into from
Mar 19, 2025

Conversation

NGPixel
Copy link
Member
@NGPixel NGPixel commented Mar 17, 2025

Fixes #8682

@NGPixel NGPixel requested a review from rjsparks March 17, 2025 04:44
@codecov Codecov
Copy link
codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (70bf2ae) to head (a167f11).
Report is 41 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8685      +/-   ##
==========================================
- Coverage   88.88%   88.80%   -0.09%     
==========================================
  Files         312      314       +2     
  Lines       40891    41243     +352     
==========================================
+ Hits        36345    36624     +279     
- Misses       4546     4619      +73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks
Copy link
Member

Would be nice if we had a set of tests that would track changes like this.

@NGPixel
Copy link
Member Author
NGPixel commented Mar 17, 2025

We don't test the calendar component (other than opening the modal and validating the buttons around it) because it's an external library.

@rjsparks rjsparks merged commit c3a296f into ietf-tools:main Mar 19, 2025
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjsparks rjsparks rjsparks approved these changes

@jennifer-richards jennifer-richards jennifer-richards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calendar view display - local time
3 participants
@NGPixel @rjsparks @jennifer-richards
0