fix: guard against KeyError in telechat_page_count #8485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
approved these changes
Jan 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8485 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 312 312
Lines 40886 40856 -30
=======================================
- Hits 36307 36284 -23
+ Misses 4579 4572 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes server errors when a pre-AD views the
agenda_documentsview.The root cause of the issue is including pre-AD roles here:
datatracker/ietf/iesg/views.py
Line 363 in cb25831
The
advalue set in that view is only used to compute the pages left to ballot, where it's assumed that theadwill be an active balloter. The bug being fixed comes from that assumption being violated.