[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution docs update #357

Merged
merged 12 commits into from
Jul 19, 2022
Merged

Contribution docs update #357

merged 12 commits into from
Jul 19, 2022

Conversation

strobeflash
Copy link
Contributor
@strobeflash strobeflash commented Jul 15, 2022 •
edited
Loading

Rewrote the contribution docs to match the new release workflow and tooling.
Could not test the actual release process but hopefully close enough.

@strobeflash strobeflash mentioned this pull request Jul 15, 2022
Merged
@C4ptainCrunch C4ptainCrunch marked this pull request as draft July 18, 2022 09:30
@C4ptainCrunch C4ptainCrunch changed the title draft for documentation Contribution docs update Jul 18, 2022
C4ptainCrunch
C4ptainCrunch requested changes Jul 18, 2022
View reviewed changes
Copy link
Member
@C4ptainCrunch C4ptainCrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! If we address the few remarks, this seems good enough to be merged in the hatch branch and in turn merge it too ! 🥳

CONTRIBUTING.rst Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@C4ptainCrunch C4ptainCrunch marked this pull request as ready for review July 18, 2022 09:41
strobeflash and others added 10 commits July 19, 2022 09:52
@strobeflash
add tox to pip install
8f89cc6
@strobeflash @C4ptainCrunch
specify tag version
31d3563 
Co-authored-by: 0xC4 <nikita.marchant@gmail.com>
@strobeflash
fix typo
8711ee1
@strobeflash
add links
515514e
@strobeflash @C4ptainCrunch
rename
7eea824 
Co-authored-by: 0xC4 <nikita.marchant@gmail.com>
@strobeflash
remove hatch publish
da9af66 
publishing to pypi is covered by github action
@strobeflash
reorder steps
5bb573d
@strobeflash
Revert "remove hatch publish"
2951d9c 
This reverts commit da9af66.
@strobeflash
Replace git push with hatch publish
574f741
@strobeflash
Replace build env setup with reference
752f653
@C4ptainCrunch C4ptainCrunch merged commit 24f0c7a into ics-py:hatch Jul 19, 2022
@C4ptainCrunch
Copy link
Member

Thank you @strobeflash 👍

@strobeflash strobeflash deleted the hatch branch July 19, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C4ptainCrunch C4ptainCrunch C4ptainCrunch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strobeflash @C4ptainCrunch