8000 Fix svg png same url by vmcj · Pull Request #1115 · icpctools/icpctools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix svg png same url #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Fix svg png same url #1115

wants to merge 7 commits into from

Conversation

vmcj
Copy link
Collaborator
@vmcj vmcj commented May 20, 2025 •
edited
Loading

This should fix the the /organizations/id/logo.{svg,png} issue. Only opening this to make sure no one else works on this in parallel. Did not test with the presentation client yet if it works out of the box.

  • The URLs are resolvable and provide the right file.
  • The warning about the re-used URL would run on every check for directory changes. This is a bit verbose as this shouldn't happen in practice I think a bit of verbosity is less of an issue (although ugly).
  • There is a remark that the current code wouldn't handle a similar case, I'm not sure if its besides similar really this case so I left the TODO for now.
  • I suspect the ext can be added in a better way, this was the result of a long flight of debugging (and not much changes in the end) but a second pass will be needed.

@nickygerritsen nickygerritsen mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vmcj
0