8000 fix: auth expiration error by alexespejo · Pull Request #1296 · icssc/AntAlmanac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: auth expiration error #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2025
Merged

fix: auth expiration error #1296

merged 3 commits into from
Jun 19, 2025

Conversation

alexespejo
Copy link
Contributor
@alexespejo alexespejo commented Jun 19, 2025 •
edited
Loading

Summary

Issue: The code that authenticates the user takes a token arguement and it was passing the expired token but didn't validate the token. However, validating the token is unnecessary here because this bug is only caused when the user first logs in, so the the old token is trivial.

When session expires, prompt user to log back in
image

Test Plan

  1. In the DB, filter for your account in users and associated session rows
  2. Login with your email
  3. Manually set the expiration_date to some day in the past
  4. Refresh page (should be prompted to log back in)
  5. Attempt login
  6. Note: Logging in and out normally shouldn't be affected

Issues

Closes #

alexespejo
alexespejo commented Jun 19, 2025
View reviewed changes
@alexespejo alexespejo marked this pull request as ready for review June 19, 2025 19:24
KevinWu098
KevinWu098 approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member
@KevinWu098 KevinWu098 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m on mobile so I can’t test particularly thoroughly

I trust you though

@alexespejo alexespejo removed the request for review from MinhxNguyen7 June 19, 2025 20:29
@alexespejo alexespejo merged commit d4f7b1b into main Jun 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexespejo @KevinWu098
0