8000 Add simple tests to make sure notebooks run by markstur · Pull Request #34 · ibm-granite/granite-io · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add simple tests to make sure notebooks run #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 4, 2025
Merged

Add simple tests to make sure notebooks run #34

merged 8 commits into from
Mar 4, 2025

Conversation

markstur
Copy link
Collaborator

@markstur markstur marked this pull request as draft February 28, 2025 23:02
@markstur markstur changed the title Add simple test to make sure notebooks run Add simple tests to make sure examples and notebooks run Mar 1, 2025
@markstur markstur changed the title Add simple tests to make sure examples and notebooks run Add simple tests to make sure notebooks run Mar 1, 2025
frreiss
frreiss reviewed Mar 1, 2025
View reviewed changes
@markstur markstur marked this pull request as ready for review March 3, 2025 16:27
markstur added 8 commits March 3, 2025 11:23
@markstur
Add simple test to make sure notebooks run
0287be2 
* tox -e notebooks
* No output tests now, but can fail when we change code
* Updated notebook for future PR ibm-granite#30 (asyncio)

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur
fix ruff and try to clean up notebook changes
67a458a 
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur
Need hub to get model for CI
ed2d615 
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur
Revert notebook back to main
ddf14de 
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur
Test examples
2444e03 
Have tox run examples to see if they still run.

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur
CI test examples to see if they still run
cead64d 
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur
Don't run examples in CI because they need ollama running
b3b3b58 
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur
Use 2b model for notebook
7f68dca 
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
frreiss
frreiss approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator
@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frreiss frreiss merged commit 6f32ffc into ibm-granite:main Mar 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frreiss frreiss frreiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markstur @frreiss
0