8000 chore: formatting pydantic field doc strings for GenerateInputs by markstur · Pull Request #97 · ibm-granite/granite-io · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: formatting pydantic field doc strings for GenerateInputs #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

markstur
Copy link
Collaborator
@markstur markstur commented Mar 22, 2025

Using the same style as pydantic.BaseModel allows the field doc strings to show on hovers for vscode or pycharm.

Closes: #93

@markstur markstur force-pushed the issue_93 branch 2 times, most recently from 2d8eea8 to 03c7e89 Compare March 26, 2025 00:18
Copy link
Collaborator
@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator
@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markstur do you mind fixing the ruff issue?

Using the same style as pydantic.BaseModel allows the field
doc strings to show on hovers for vscode or pycharm.

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@hickeyma hickeyma merged commit a313918 into ibm-granite:main Apr 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydoc comment for GenerateInputs is improperly formatted
3 participants
0