8000 !feat: Support multiple completions in backends by markstur · Pull Request #48 · ibm-granite/granite-io · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

!feat: Support multiple completions in backends #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 6, 2025

Conversation

markstur
Copy link
Collaborator
@markstur markstur commented Mar 4, 2025

Generate multiple completions for a single prompt by adding the num_return_sequences parameter.

This has limited support by the providers. The parameter for the providers can have different names and may require a 2nd parameter is also used.

The changing of results returned to be a list is a breaking change.

Closes: #37

markstur added 2 commits March 4, 2025 15:37
Generate multiple completions for a single prompt by
adding the num_return_sequences parameter.

This has limited support by the providers. The parameter for
the providers can have different names and may require a 2nd
parameter is also used.

The changing of results returned to be a list is a breaking change.

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
* Only test_backends.py for now
* Adding recorded cassettes (manual/default)
* By default, record mode is none. So tests use cassettes, but fail if more are needed.

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
markstur added 8 commits March 4, 2025 16:29
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
* notebook install is smaller than full jupyter
* Going back to running command instead of leveraging tox
  to try to avoid running out of space (faster would be nice too)

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
* Pin to older vcrpy to avoid flakey httpx.ResponseNotRead
* Added retry as well, but those might not be needed anymore (we'll see)
* Added tox -e record (to rewrite recordings and self doc)
* Added block-network settings to help ensure recordings are used

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Copy link
Collaborator
@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markstur markstur merged commit c5e3dff into ibm-granite:main Mar 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple completions in backends
2 participants
0