ci: Add workflow to test python script examples #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33da7a4 to
2f72a0d
Compare
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2f72a0d to
e0e0145
Compare
markstur
reviewed
Mar 3, 2025
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
markstur
reviewed
Mar 3, 2025
| 8000 | - name: Install Ollama and start server | |
| shell: bash | ||
| run: | | ||
| curl -fsSL https://ollama.com/install.sh | sudo -E sh |
There was a problem hiding this comment.
Also, I was looking at examples of this and was always wondering if we need to try to kill the ollama server at the end (capture the pid or pkill). But I wasn't finding good examples so perhaps CI shuts everything down okay? I mean it should shut down all subprocesses and not hang CI resources, right?
There was a problem hiding this comment.
Hmmm .. not sure. I'll investigate this further.
There was a problem hiding this comment.
Is it ok to do this post PR merge?
- model_chat_with_thinking.py - watsonx_litellm.py Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
1 Python version is good enough for now. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
This more efficient instead of separate runners using matrix in workflow. Co-authored-by: Mark Sturdevant <mark.sturdevant@ibm.com> Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
6ad67a3 to
a396a0a
Compare
Its ok now. It might have been at start when adding intermediate fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pu
2C36
ll request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.