feat(cmake): enhance internal unicode + hyperlink detection for running under cmake-gui #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng under cmake-gui `CMAKE_EDIT_COMMAND` will point to `cmake-gui` if it was executed via this tool, so we can easily detect if the user can see/read unicode and if terminal hyperlinks are supported. While `ccmake`, the TUI version of `cmake-gui` might be set as the `CMAKE_EDIT_COMMAND` we ignore it as it's going to be running under a terminal environment *anyhow*. Signed-off-by: Izzy Muerte <63051+bruxisma@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_EDIT_COMMANDwill point tocmake-guiif it was executed via this tool, so we can easily detect if the user can see/read unicode and if terminal hyperlinks are supported. Whileccmake, the TUI version ofcmake-guimight be set as theCMAKE_EDIT_COMMANDwe ignore it as it's going to be running under a terminal environment anyhow.