fix premake versioning on forks; remove unused versioning vars #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3B5C
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix git (and premake) related build issues on forks.
rel. #150
How does this PR change IW4x's behaviour?
So this is the cool part, it doesn't! This is the groundbreaking change that will revolutionize your gaming experience. Brace yourselves, for this PR does not alter the gameplay in any way. No, this is not some game-breaking update with new features or hidden Easter eggs. Instead, it performs the critical task of removing unused variables from the version.h file. Yes, that’s right—unused variables. These rogue pieces of code, doing absolutely nothing, are now gone. You can rest easy knowing that every line of code is now working as efficiently as possible, even if it wasn’t actually doing anything in the first place. Truly, this is the patch we've all been waiting for.
Anything else we should know?
@wroyca would prefer using os.chdir in
prebuildcommands, but I couldn't get it to work 🐒