Skip MOTD periodic updates #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rackover
approved these changes
Jan 19, 2025
polling every 3 minutes for MOTD update is wasteful, especially since content rarely changes. Instead, we can simplify implementation by fetching MOTD once during initialization and skipping periodic updates altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polling every 3 minutes for MOTD update is wasteful, especially since content rarely changes. Instead, we can simplify implementation by fetching MOTD once during initialization and skipping periodic updates altogether.
This also removes the wine check that prevented changelog and MOTD from loading. Not sure why it was introduced, and blame doesn't reveal much about it:
Before
After