8000 Add config option to display source code URL in footer by SamantazFox · Pull Request #2450 · iv-org/invidious · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add config option to display source code URL in footer #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

SamantazFox
Copy link
Member
@SamantazFox SamantazFox commented Oct 3, 2021

This is not the greatest fix, but it provides an easy way for instance maintainers to put a link to the modified source code in order to comply with the AGPL.

Response to the feedback received in iv-org/documentation#148 and iv-org/documentation#149

It also adds translation entries for a few missing strings of the footer.

@TheFrenchGhosty
Copy link
Member

Can you name the value modified_source_code_url, so that the value name is clear, otherwise perfect.

@SamantazFox
Copy link
Member Author

Can you name the value modified_source_code_url, so that the value name is clear, otherwise perfect.

you mean, rename the config option?

@TheFrenchGhosty
Copy link
Member

Yes, exactly. (If it's too time consuming don't bother it's not a big deal).

@SamantazFox
Copy link
Member Author

Yes, exactly. (If it's too time consuming don't bother it's not a big deal).

nah, sure, if you think it's clearer!

@SamantazFox
Copy link
Member Author
SamantazFox commented Oct 3, 2021

oops, copy/pasta error

@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Oct 3, 2021
@SamantazFox SamantazFox merged commit adc12ad into iv-org:master Oct 7, 2021
@SamantazFox SamantazFox deleted the footer-url-config branch October 7, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0