fix: content-disposition-header added #5234
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
reviewed
May 15, 2025
| @@ -321,6 +321,9 @@ module Invidious::Routes::Watch | |||
| env.params.query["title"] = filename | |||
| env.params.query["label"] = URI.decode_www_form(label.as_s) | |||
|
|
|||
| # Set content disposition header to force download | |||
| env.response.headers["Content-Disposition"] = "attachment; filename=\"#{filename}\"" | |||
There was a problem hiding this comment.
Please also add the filename* parameter needed for handling utf-8 strings on modern browsers.
See https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Content-Disposition#as_a_response_header_for_the_main_body for more information.
Implementation reference for the encoding: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent#encoding_for_content-disposition_and_link_headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added content-disposition-header for downloading the file.
Closes #5211