Use individual funcs, skipping the ExecuteOpInternal switch #5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -382,6 +383,8 @@ static const CommandTableEntry commandTable[] = { | |||
| {GE_CMD_UNKNOWN_FF, FLAG_EXECUTE}, | |||
| }; | |||
|
|
|||
| GLES_GPU::CmdFunc GLES_GPU::cmdFuncs_[256]; | |||
There was a problem hiding this comment.
I wonder if we should combine this and commandFlags[] into one array of struct { flags, CmdFunc }, so that the lookup will fetch both things at once into cache.
There was a problem hiding this comment.
That sounds like a good idea.
-[Unknown]
Rather than a single one, ExecuteOpInternal(). This allows less "huge switch" code organization, and will (once separated) also improve speed.
2% improvement in God Eater 2.
Seems not to make a big difference, though.
hrydgard
added a commit
that referenced
this pull request
Apr 17, 2014
Use individual funcs, skipping the ExecuteOpInternal switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps on x86, but I'm having trouble on ARM - it's just not consistent numbers enough, and I can't do it properly with headless. It'd be good if someone else could verify the performance on Android.
The numbers aren't entirely consistent on x86. I got better than 1% in a couple places, but when I retry them they sometimes aren't as much faster... anyway, it's 1% better in several places.
-[Unknown]