Integrate Dolphin's granule based audio resampler #20432
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05e050f to
3119eab
Compare
f0482b9 to
5b37c52
Compare
This was referenced Jun 16, 2025
Removed parts of it that were not relevant. Working, it seems. Not sure about the buffer size thing. See #20146 and dolphin-emu/dolphin#13352
8000
…he maximum queue size should be.
5b37c52 to
632f9ed
Compare
|
This is starting to work fairly well now - on Windows with WASAPI at least. Needs a bit more buffer size tuning, but mostly, audio latency is reduced and quality improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for 1.19, needs more testing.
Working fairly well, it seems, though need to properly integrate the buffer size checking. Draft for now.
See #20146 and dolphin-emu/dolphin#13352
Actually, before this I'm going to re-work our WASAPI backend with modern low-latency options: https://learn.microsoft.com/en-us/windows-hardware/drivers/audio/low-latency-audio#Measurement_Tools