Change GraalVM build process to allow multiple Clikt commands + some oauth starting #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pausing' or something
hrothwell
commented
Oct 4, 2022
| val client_id: String | ||
| val client_id: String, | ||
| // val oauth_authorization_code: String?, | ||
| // val oauth_token: String? // TODO fine to keep this here? |
There was a problem hiding this comment.
need to ignore missing keys or something using kotlinx, didn't wanna bother with it rn
hrothwell
commented
Oct 4, 2022
Comment on lines
+9
to
+12
| call java -agentlib:native-image-agent=config-merge-dir=%configPath% -jar %root%build\libs\anime-cli-1.0-SNAPSHOT-all.jar | ||
| call java -agentlib:native-image-agent=config-merge-dir=%configPath% -jar %root%build\libs\anime-cli-1.0-SNAPSHOT-all.jar login | ||
| call java -agentlib:native-image-agent=config-merge-dir=%configPath% -jar %root%build\libs\anime-cli-1.0-SNAPSHOT-all.jar random | ||
| call java -agentlib:native-image-agent=config-merge-dir=%configPath% -jar %root%build\libs\anime-cli-1.0-SNAPSHOT-all.jar random -u hone_the_rat -l completed |
There was a problem hiding this comment.
see documentation on agentlib
It can be necessary to run the target application more than once with different inputs to trigger separate execution paths for a better coverage of dynamic accesses. The agent supports this with the config-merge-dir option which adds the intercepted accesses to an existing set of configuration files
I read it and literally didn't even think about that until hours in 🤦
This was referenced Oct 4, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting the oauth process as documented by mal. need to figure out 'pausing' or somethingThis PR got taken over by fixing native-image stuff with using subcommands(). I literally jumped out of bed at 12am to do this because I remembered reading this in the documentation for agentlib